From 9be4cd188a9210ba1dadaf7b885ab33485a46236 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nils=20O=2E=20Sel=C3=A5sdal?= Date: Tue, 8 Sep 2026 20:16:11 +0200 Subject: [PATCH] Fix the stale logging rule and drop go test from the README --- .clinerules | 5 +++-- README.md | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.clinerules b/.clinerules index 1ab64ad..b11e168 100644 --- a/.clinerules +++ b/.clinerules @@ -71,8 +71,9 @@ This service runs in Kubernetes behind a TLS-terminating ingress. - All upload code paths must enforce `maxUploadSize` via `http.MaxBytesReader`, and clean up any partially written file/directory on failure. -- New HTTP handlers must call `logRequest` with an accurate status code for - every response path. +- New HTTP handlers must write an explicit status code on every response + path. The `withLogging` middleware records what `responseRecorder` actually + saw, so a handler that returns without writing is logged as a 200. - Keep the JSON error shape for `/upload` consistent with `writeMultipartError` (`{"error": "..."}`). diff --git a/README.md b/README.md index 326e62c..8756bdf 100644 --- a/README.md +++ b/README.md @@ -109,7 +109,7 @@ to write to whatever is mounted at `/uploads`. ## Development ```sh -go build ./... && go vet ./... && gofmt -l . && go test ./... +go build ./... && go vet ./... && gofmt -l . ``` Run locally: