noselasd/libucore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use snprintf over sprintf

Browse Source
This commit is contained in:
Nils O. Selåsdal
2014-04-23 22:40:37 +02:00
parent 10c0e37253
commit d9bb5315f8
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/logging.c
+3 -4
View File
@@ -613,15 +613,14 @@ static void uc_log_file_rotate_size(struct UCLogDestination *dest)
//rotate existing .num files //rotate existing .num files
i = dest->type.file.rotate.size_settings.num_files -1; i = dest->type.file.rotate.size_settings.num_files -1;
while (i > 0) { while (i > 0) {
sprintf(new_filename, "%s.%d", dest->type.file.file_name, i); snprintf(new_filename, sizeof new_filename, "%s.%d", dest->type.file.file_name, i);
sprintf(old_filename, "%s.%d", dest->type.file.file_name, i - 1); snprintf(old_filename, sizeof old_filename, "%s.%d", dest->type.file.file_name, i - 1);
rename(old_filename, new_filename); rename(old_filename, new_filename);
i--; i--;
} }
sprintf(new_filename, "%s.0", dest->type.file.file_name);
//rename current file //rename current file
sprintf(new_filename, "%s.0", dest->type.file.file_name);
rename(dest->type.file.file_name, new_filename); rename(dest->type.file.file_name, new_filename);
//re-open current file //re-open current file